uclibc: Resolve build errors due to __SIZEOF_PTHREAD_COND_T and NLMSG_MIN_TYPE #4915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
force-pushed
the
fix-uclibc
branch
3 times, most recently
from
d2b0007 to
402d74f
Compare
tgross35
added
the
stable-nominated
Resolves a uclibc build error introduced in the "Fixes" commit. Fixes: 2fe1d91 ("Separate L4Re from Linux code and enable tests")
Move netlink types defined in UAPI to the `new` module. This resolves
the following build error on uclibc platforms:
error[E0425]: cannot find value `NLMSG_MIN_TYPE` in the crate root
--> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/libc-0.2.179/src/unix/linux_like/linux/mod.rs:1999:48
|
1999 | pub const NFNL_MSG_BATCH_BEGIN: c_int = crate::NLMSG_MIN_TYPE;
| ^^^^^^^^^^^^^^ not found in the crate root
|
note: found an item that was configured out
--> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/libc-0.2.179/src/unix/linux_like/linux_l4re_shared.rs:1222:19
|
1200 | if #[cfg(not(target_env = "uclibc"))] {
| ----------------------- the item is gated here
...
1222 | pub const NLMSG_MIN_TYPE: c_int = 0x10;
| ^^^^^^^^^^^^^^
Fixes: 2fe1d91 ("Separate L4Re from Linux code and enable tests")
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
tgross35
force-pushed
the
fix-uclibc
branch
3 times, most recently
from
7e62817 to
394ebaf
Compare
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Jan 8, 2026
Resolves a uclibc build error introduced in the "Fixes" commit. Fixes: 2fe1d91 ("Separate L4Re from Linux code and enable tests") (backport <rust-lang#4915>) (cherry picked from commit 3dad489)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Jan 8, 2026
Move netlink types defined in UAPI to the `new` module. This resolves
the following build error on uclibc platforms:
error[E0425]: cannot find value `NLMSG_MIN_TYPE` in the crate root
--> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/libc-0.2.179/src/unix/linux_like/linux/mod.rs:1999:48
|
1999 | pub const NFNL_MSG_BATCH_BEGIN: c_int = crate::NLMSG_MIN_TYPE;
| ^^^^^^^^^^^^^^ not found in the crate root
|
note: found an item that was configured out
--> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/libc-0.2.179/src/unix/linux_like/linux_l4re_shared.rs:1222:19
|
1200 | if #[cfg(not(target_env = "uclibc"))] {
| ----------------------- the item is gated here
...
1222 | pub const NLMSG_MIN_TYPE: c_int = 0x10;
| ^^^^^^^^^^^^^^
Fixes: 2fe1d91 ("Separate L4Re from Linux code and enable tests")
(backport <rust-lang#4915>)
(cherry picked from commit e0ed72d)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Jan 8, 2026
(backport <rust-lang#4915>) (cherry picked from commit 68d3a77)
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 8, 2026
Move netlink types defined in UAPI to the `new` module. This resolves
the following build error on uclibc platforms:
error[E0425]: cannot find value `NLMSG_MIN_TYPE` in the crate root
--> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/libc-0.2.179/src/unix/linux_like/linux/mod.rs:1999:48
|
1999 | pub const NFNL_MSG_BATCH_BEGIN: c_int = crate::NLMSG_MIN_TYPE;
| ^^^^^^^^^^^^^^ not found in the crate root
|
note: found an item that was configured out
--> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/libc-0.2.179/src/unix/linux_like/linux_l4re_shared.rs:1222:19
|
1200 | if #[cfg(not(target_env = "uclibc"))] {
| ----------------------- the item is gated here
...
1222 | pub const NLMSG_MIN_TYPE: c_int = 0x10;
| ^^^^^^^^^^^^^^
Fixes: 2fe1d91 ("Separate L4Re from Linux code and enable tests")
(backport <#4915>)
(cherry picked from commit e0ed72d)
tgross35
added
stable-applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details are in the commit messages.