Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docker flags that can cause issues #579

Merged
merged 1 commit into from
Apr 23, 2017

Conversation

aidanhs
Copy link
Member

@aidanhs aidanhs commented Apr 23, 2017

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Apr 23, 2017

📌 Commit fef01d6 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Apr 23, 2017

⌛ Testing commit fef01d6 with merge 30d665a...

bors added a commit that referenced this pull request Apr 23, 2017
@bors
Copy link
Contributor

bors commented Apr 23, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 30d665a to master...

@bors bors merged commit fef01d6 into rust-lang:master Apr 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants