Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run s390x tests on qemu system #820

Merged
merged 2 commits into from
Oct 31, 2017
Merged

Run s390x tests on qemu system #820

merged 2 commits into from
Oct 31, 2017

Conversation

malbarbo
Copy link
Contributor

@malbarbo malbarbo commented Oct 27, 2017

qemu in user mode cannot run binaries produced by rustc (it hangs), so we run the tests in a fully virtualized s390x machine using qemu-system-s390x.

Some constants had to be fixed.

@malbarbo
Copy link
Contributor Author

Android tests are failing. Maybe https://travis-ci.org/rust-lang/libc/jobs/293607888#L4848

Download finished with wrong checksum. Expected b8130e7c390496cff12bf9355739bd41eed6a0a5, got 668ff8e319715175ff628ad52b124f154275fe2d.

@alexcrichton
Copy link
Member

Nice!

Something about the android tests do indeed look funny, I'll take a look. Looks like s390x is also failing?

@alexcrichton
Copy link
Member

@malbarbo so it looks like the Android docker images no longer have adb, presumably something about the downloads changed?

I think you've done some work with Android/CI in the past, mind helping me investigate? It looks like the android command we're using is deprecated in favor of some others, and I'm curious if you happen to already know off the top of your head how to move to the non-deprecated versions?

@malbarbo
Copy link
Contributor Author

@alexcrichton I'm trying to solve the android issue.

@alexcrichton
Copy link
Member

Awesome, thanks!

@malbarbo malbarbo force-pushed the s390x-test branch 2 times, most recently from 59038c4 to ff1b2cf Compare October 27, 2017 20:40
@malbarbo
Copy link
Contributor Author

I've tried many things but none made s390x builder works... It works locally...

Next week I will take a look at this again.

@alexcrichton
Copy link
Member

Oops sorry didn't mean to close.

I see you installed binfmt support in the container, is that needed to run foreign binaries? I haven't looked too closely at this yet, but historically I've seen the need for installing that package outside the container as well, for example directly on Travis , maybe that's what is up?

@malbarbo malbarbo force-pushed the s390x-test branch 7 times, most recently from f33efca to 8ba5798 Compare October 28, 2017 01:15
@bors
Copy link
Contributor

bors commented Oct 28, 2017

☔ The latest upstream changes (presumably #825) made this pull request unmergeable. Please resolve the merge conflicts.

@malbarbo
Copy link
Contributor Author

I have changed to a simpler (and faster) approach that do not use qemu-user. Hopefully this will work on travis. I'm testing this approach with sparc64.

@alexcrichton
Copy link
Member

@bors: r+

Nice!

@bors
Copy link
Contributor

bors commented Oct 31, 2017

📌 Commit a6c7091 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Oct 31, 2017

⌛ Testing commit a6c7091 with merge f150863...

bors added a commit that referenced this pull request Oct 31, 2017
Run s390x tests on qemu system

qemu in user mode cannot run binaries produced by rustc (it hangs), so we run the tests in a fully virtualized s390x machine using qemu-system-s390x.

Some constants had to be fixed.
@alexcrichton
Copy link
Member

This feels "more correct" to me in terms of emulation in QEMU, so if this is easily adaptable to other architectures I'd be totally on board with doing this across the board for all cross-compiled arches

@bors
Copy link
Contributor

bors commented Oct 31, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing f150863 to master...

@bors bors merged commit a6c7091 into rust-lang:master Oct 31, 2017
@malbarbo
Copy link
Contributor Author

I opened #829 issue to track the use of qemu system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants