-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run s390x tests on qemu system #820
Conversation
Android tests are failing. Maybe https://travis-ci.org/rust-lang/libc/jobs/293607888#L4848
|
Nice! Something about the android tests do indeed look funny, I'll take a look. Looks like s390x is also failing? |
@malbarbo so it looks like the Android docker images no longer have I think you've done some work with Android/CI in the past, mind helping me investigate? It looks like the |
@alexcrichton I'm trying to solve the android issue. |
Awesome, thanks! |
59038c4
to
ff1b2cf
Compare
I've tried many things but none made s390x builder works... It works locally... Next week I will take a look at this again. |
Oops sorry didn't mean to close. I see you installed binfmt support in the container, is that needed to run foreign binaries? I haven't looked too closely at this yet, but historically I've seen the need for installing that package outside the container as well, for example directly on Travis , maybe that's what is up? |
f33efca
to
8ba5798
Compare
☔ The latest upstream changes (presumably #825) made this pull request unmergeable. Please resolve the merge conflicts. |
I have changed to a simpler (and faster) approach that do not use qemu-user. Hopefully this will work on travis. I'm testing this approach with sparc64. |
@bors: r+ Nice! |
📌 Commit a6c7091 has been approved by |
Run s390x tests on qemu system qemu in user mode cannot run binaries produced by rustc (it hangs), so we run the tests in a fully virtualized s390x machine using qemu-system-s390x. Some constants had to be fixed.
This feels "more correct" to me in terms of emulation in QEMU, so if this is easily adaptable to other architectures I'd be totally on board with doing this across the board for all cross-compiled arches |
☀️ Test successful - status-appveyor, status-travis |
I opened #829 issue to track the use of qemu system. |
qemu in user mode cannot run binaries produced by rustc (it hangs), so we run the tests in a fully virtualized s390x machine using qemu-system-s390x.
Some constants had to be fixed.