Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default RHS to Self for Div and Shl #964

Merged
merged 1 commit into from
Apr 6, 2018
Merged

Conversation

npmccallum
Copy link
Contributor

This fixes a consistency issue with the other operator traits.

This fixes a consistency issue with the other operator traits.
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

Thanks! These are just used during documentation, however, so is this change required for correctness?

@npmccallum
Copy link
Contributor Author

@alexcrichton I assumed it would be required for correct documentation. :)

@alexcrichton
Copy link
Member

Oh we don't actually document these traits as part of the build, they're just required to document other things (it's sort of a hack today)

@npmccallum
Copy link
Contributor Author

I don't take this patch to be urgent. I just took it to be easy while I was fixing the actual code in the rust bug. :)

rust-lang/rust#49630

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Apr 6, 2018

📌 Commit 585e115 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Apr 6, 2018

⌛ Testing commit 585e115 with merge cc835c9...

bors added a commit that referenced this pull request Apr 6, 2018
Default RHS to Self for Div and Shl

This fixes a consistency issue with the other operator traits.
@bors
Copy link
Contributor

bors commented Apr 6, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing cc835c9 to master...

@bors bors merged commit 585e115 into rust-lang:master Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants