Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Licensing issues? #73

Closed
porglezomp opened this issue Jul 14, 2018 · 8 comments
Closed

Licensing issues? #73

porglezomp opened this issue Jul 14, 2018 · 8 comments

Comments

@porglezomp
Copy link
Contributor

The musl libc implementations include lines like the following:

/* origin: FreeBSD /usr/src/lib/msun/src/k_cos.c */
/*
 * ====================================================
 * Copyright (C) 1993 by Sun Microsystems, Inc. All rights reserved.
 *
 * Developed at SunSoft, a Sun Microsystems, Inc. business.
 * Permission to use, copy, modify, and distribute this
 * software is freely granted, provided that this notice
 * is preserved.
 * ====================================================
 */

Should these remain present in the ported versions, given that these seem to me like a derived work?

@japaric
Copy link
Member

japaric commented Jul 14, 2018

IANAL but we probably want to keep the license headers and also have a COPYRIGHT file MUSL does. I'm not sure though -- compiler-builtins, a Rust port of compiler-rt, doesn't keep the license headers (but those are more homogeneous); it just contains a copy of compiler-rt license.

@alexcrichton @steveklabnik assuming this will end up as a submodule of rust-lang/rust what should we do wrt to licensing and copyright notices?

@steveklabnik
Copy link
Member

steveklabnik commented Jul 14, 2018 via email

@porglezomp
Copy link
Contributor Author

Just to clarify since I'm not sure which of these you mean Steve: we're asking about the Sun Microsystems headers that were already in the MUSL code that's being ported, not Rust license headers.

@steveklabnik
Copy link
Member

steveklabnik commented Jul 14, 2018 via email

bors bot added a commit that referenced this issue Jul 14, 2018
88: add license and other comments to existing files r=japaric a=erikdesjardins

re #73

Co-authored-by: Erik <erikdesjardins@users.noreply.github.com>
@japaric
Copy link
Member

japaric commented Jul 14, 2018

are you planning a submodule for sure? Why not a regular crate?

Some of the math code may end in core (which can't depend on any crate); the rest will go into compiler-builtins (which can only depend on core). The code will be source imported (#[path = ..] mod libm); due to these constraints and that requires a submodule.

@alexcrichton
Copy link
Member

Unfortunately I have little knowledge about what this means, I don't know what we need to do in terms of licensing :(

@japaric
Copy link
Member

japaric commented Jul 18, 2018

For the time being all the copyright notices / headers in C files have been copied over to the Rust files. I don't know if we need anything else though.

@tgross35
Copy link
Contributor

Licensing was updated in #317. Summary:

  • This library is available for use under the MIT license, since that is what most source is derived from (musl)
  • Non-derivative contributions to this library are MIT OR Apache-2.0
  • We do need to retain copyright headers from any source files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants