-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Licensing issues? #73
Comments
IANAL but we probably want to keep the license headers and also have a COPYRIGHT file MUSL does. I'm not sure though -- compiler-builtins, a Rust port of compiler-rt, doesn't keep the license headers (but those are more homogeneous); it just contains a copy of compiler-rt license. @alexcrichton @steveklabnik assuming this will end up as a submodule of rust-lang/rust what should we do wrt to licensing and copyright notices? |
As far as I know, headers are unnneccesary. They’re still in the tree for legacy reasons but new code doesn’t use them. I think? At least, none of the crates we pull in do; are you planning a submodule for sure? Why not a regular crate?
… On Jul 13, 2018, at 10:13 PM, Jorge Aparicio ***@***.***> wrote:
IANAL but we probably want to keep the license headers and also have a COPYRIGHT file MUSL does. I'm not sure though -- compiler-builtins, a Rust port of compiler-rt, doesn't keep the license headers (but those are more homogeneous); it just contains a copy of compiler-rt license.
@alexcrichton @steveklabnik assuming this will end up as a submodule of rust-lang/rust what should we do wrt to licensing and copyright notices?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Just to clarify since I'm not sure which of these you mean Steve: we're asking about the Sun Microsystems headers that were already in the MUSL code that's being ported, not Rust license headers. |
Ah! Yes I was confused. Ignore my previous post.
… On Jul 14, 2018, at 7:51 AM, C Jones ***@***.***> wrote:
Just to clarify since I'm not sure which of these you mean Steve: we're asking about the Sun Microsystems headers that were already in the MUSL code that's being ported, not Rust license headers.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Some of the math code may end in core (which can't depend on any crate); the rest will go into compiler-builtins (which can only depend on core). The code will be source imported ( |
Unfortunately I have little knowledge about what this means, I don't know what we need to do in terms of licensing :( |
For the time being all the copyright notices / headers in C files have been copied over to the Rust files. I don't know if we need anything else though. |
Licensing was updated in #317. Summary:
|
The musl libc implementations include lines like the following:
Should these remain present in the ported versions, given that these seem to me like a derived work?
The text was updated successfully, but these errors were encountered: