Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove comments that don't fit our license #241

Closed
wants to merge 2 commits into from
Closed

Remove comments that don't fit our license #241

wants to merge 2 commits into from

Conversation

Lokathor
Copy link
Contributor

This should resolve #215

Per the latest comment on the issue, we just have to remove the comments, we don't have to actually change our rust code.

I've let stay:

  • Comments indicating where the ported code came from, which naturally must have been written by someone doing the rust work.
  • Comments that are a math expression without any English (which should be "a fact" and not copyright-able, i think).
  • Comments that were obviously added by someone writing the Rust, such as FIXME/TODO, explanations of when we're trying to get LLVM to do the right thing, etc.

Also I've added a blank rustfml.toml which should ensure that the crate always uses the default format settings.

This should be ready for review. I may have removed too much or too little of the comments, but there should be no code changes.

@BartMassey
Copy link

Rather than this, I would prefer to see #241 resolved as suggested by @joshtriplett there: put the original copyright notices back.

@joshtriplett
Copy link
Member

We should not be trying to delete comments in order to get out of preserving copyright notices. We should just preserve the copyright notices, and put them in the COPYRIGHT file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package is incorrectly licensed Apache/MIT
3 participants