Reenable the use of the force-soft-floats feature #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an infinite recursion in sqrt for codegen backends that implement intrinsics like simd_fsqrt by calling sqrt on every element of the vector.
antoyo
force-pushed
the
fix/infinite-recursion-sqrt
branch
from
7b22576 to
9f5e58d
Compare
antoyo
force-pushed
the
fix/infinite-recursion-sqrt
branch
from
9f5e58d to
ab5f6e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an infinite recursion in sqrt for codegen backends that implement intrinsics like simd_fsqrt by calling sqrt on every element of the vector.
This is going to be needed to fix rust-lang/compiler-builtins#649.
I was able to test this locally by changing some other code (basically having an implementation of
_mm_sqrt_pdthat calls the localsqrtfunction on all elements of the vector).Do you have any ideas for how to add a test for this? Perhaps by including this implementation of
_mm_sqrt_pdbehind a#[cfg]?