Skip to content
This repository has been archived by the owner on Aug 12, 2021. It is now read-only.

Cleanup #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Cleanup #17

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented May 8, 2019

The original goal of this cleanup was to remove all uses of ref and ref mut, but I ended up doing other things too, including some potentially controversial ones:

  • Replacing a use of Option::cloned with the more explicit Option::copied, which would limit use of this crate on stable to versions 1.35 and greater. Right now the latest stable version is 1.34, but this crate cannot be used on stable yet anyway, so this is not a breaking change.
  • Deriving Debug for three public types in order to replace assert!s with assert_eq!s.
  • Removing unnecessary derefs even though they're currently the prevailing style. Another open pull request, Added very basic JUnit output #16, would add even more of them, so I'd like to get @Gilnaa's opinion on this.

@Gilnaa
Copy link
Contributor

Gilnaa commented May 8, 2019

This looks good, I guess.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant