This repository was archived by the owner on Aug 12, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original goal of this cleanup was to remove all uses of
ref
andref mut
, but I ended up doing other things too, including some potentially controversial ones:Option::cloned
with the more explicitOption::copied
, which would limit use of this crate on stable to versions 1.35 and greater. Right now the latest stable version is 1.34, but this crate cannot be used on stable yet anyway, so this is not a breaking change.Debug
for three public types in order to replaceassert!
s withassert_eq!
s.