forked from llvm/llvm-project
-
Notifications
You must be signed in to change notification settings - Fork 104
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[MIPS] Initial support for MIPS-I load delay slots
LLVM so far has only supported the MIPS-II and above architectures. MIPS-II is pretty close to MIPS-I, the major difference being that "load" instructions always take one extra instruction slot to propogate to registers. This patch adds support for MIPS-I by adding hazard handling for load delay slots, alongside MIPSR6 forbidden slots and FPU slots, inserting a NOP instruction between a load and any instruction immediately following that reads the load's destination register. I also included a simple regression test. Since no existing tests target MIPS-I, those all still pass. Issue ref: simias/psx-sdk-rs#1 I also tested by building a simple demo app with Clang and running it in an emulator. Patch by: @impiaaa Differential Revision: https://reviews.llvm.org/D122427
- Loading branch information
Showing
7 changed files
with
116 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
; RUN: llc < %s -mtriple=mips -mcpu=mips1 | FileCheck %s -check-prefixes=ALL,MIPS1 | ||
; RUN: llc < %s -mtriple=mips -mcpu=mips2 | FileCheck %s -check-prefixes=ALL,MIPS2 | ||
; RUN: llc < %s -mtriple=mips -mcpu=mips32r2 | FileCheck %s -check-prefixes=ALL,MIPS32 | ||
target datalayout = "e-m:m-p:32:32-i8:8:32-i16:16:32-i64:64-n32-S64" | ||
target triple = "mipsel-unknown-unknown-elf" | ||
|
||
; Function Attrs: noinline nounwind optnone | ||
define dso_local i32 @add_two_pointers(i32* %a, i32* %b) #0 { | ||
entry: | ||
; ALL-LABEL: add_two_pointers: | ||
%a.addr = alloca i32*, align 4 | ||
%b.addr = alloca i32*, align 4 | ||
store i32* %a, i32** %a.addr, align 4 | ||
store i32* %b, i32** %b.addr, align 4 | ||
%0 = load i32*, i32** %a.addr, align 4 | ||
%1 = load i32, i32* %0, align 4 | ||
; ALL: lw $1, 4($fp) | ||
; MIPS1: nop | ||
; MIPS2-NOT: nop | ||
; MIPS32-NOT: nop | ||
; ALL: lw $1, 0($1) | ||
%2 = load i32*, i32** %b.addr, align 4 | ||
%3 = load i32, i32* %2, align 4 | ||
; ALL: lw $2, 0($fp) | ||
; MIPS1: nop | ||
; MIPS2-NOT: nop | ||
; MIPS32-NOT: nop | ||
; ALL: lw $2, 0($2) | ||
%add = add nsw i32 %1, %3 | ||
ret i32 %add | ||
; ALL: lw $ra, 12($sp) | ||
; MIPS1: nop | ||
; MIPS2-NOT: nop | ||
; MIPS32-NOT: nop | ||
; ALL: jr $ra | ||
} | ||
|
||
attributes #0 = { noinline nounwind optnone "frame-pointer"="all" "min-legal-vector-width"="0" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-features"="-noabicalls" } | ||
|
||
!llvm.module.flags = !{!0, !1} | ||
|
||
!0 = !{i32 1, !"wchar_size", i32 4} | ||
!1 = !{i32 7, !"frame-pointer", i32 2} | ||
|