Backport "eq of parts" fold with logical ops #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently only handle this with a bitwise and/or instruction, but not a logical. (cherry picked from commit be4b836)
The pattern matched here is too complex for the general logical and/or to bitwise and/or conversion to trigger. However, the fold is poison-safe, so match it with a select root as well: https://alive2.llvm.org/ce/z/vNzzSg https://alive2.llvm.org/ce/z/Beyumt (cherry picked from commit fafe5a6)
|
LGTM. Does this need an upstream 13.x backport? Maybe not if it's just a nice-to-have optimization. |
|
Argh, I didn't mean to squash this! I could force-push fix that, if we care... |
I think the repository settings can be changed (was it in branch protection?) to disable that mode. |
Yeah, this is just nice to have, so don't need an upstream backport.
Don't think it really matters... |
vext01
pushed a commit
to vext01/llvm-project
that referenced
this pull request
Feb 26, 2024
More work on lowering LLVMIR to YKIR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the actual optimization for rust-lang/rust#83585 is part of LLVM 13, it did not trigger for logical operations. This backports the necessary patch.
I figured it would make sense to backport this rather than wait for another release cycle.