Fix nondeterminism in debuginfo generation #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for tracking this down! This has now been merged upstream. |
|
The upstream commit is 3c47c5c. |
|
Could you update the commit log to match? Especially the subject line, as that helps us keep track of upstream patches. |
Changes from commit 1db137b added iteration over hash map that can result in non-deterministic order. Fix that by using a SmallMapVector to preserve the order. Differential Revision: https://reviews.llvm.org/D113468 (cherry picked from commit 3c47c5c)
yanok
force-pushed
the
rustc/13.0-2021-09-30-dbginfo-fix
branch
from
e010759 to
e7c27bc
Compare
|
Cherry-picked from llvm:main and updated the message to reflect it's a cherry-pick. |
vext01
pushed a commit
to vext01/llvm-project
that referenced
this pull request
Mar 8, 2024
Yk assumes all pointers are the same size as a void pointer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes from commit 1db137b
added iteration over hash map that can result in non-deterministic
order. Fix that by using SmallMapVector instead.
This is accepted but not yet merged into LLVM.
Differential Revision: https://reviews.llvm.org/D113468
This is a prereq to fix rust-lang/rust#90301