[cherry-pick] Fix MIPS FPU comparisons #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MIPS I, II, and III have delay slots for floating point comparisons and floating point register transfers (mtc1, mfc1). Currently, these are not taken into account and thus broken code may be generated on these targets. This patch inserts nops as necessary, while attempting to leave the current instruction if it is safe to stay. The tests in this patch were updated by @sajattack Patch by @overdrivenpotato (Marko Mijalkovic <marko.mijalkovic97@gmail.com>) Differential Revision: https://reviews.llvm.org/D115127
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 13, 2021
Update LLVM submodule Update LLVM submodule with recent cherry-picks. In particular: * rust-lang/llvm-project#123 * rust-lang/llvm-project#124
vext01
pushed a commit
to vext01/llvm-project
that referenced
this pull request
Apr 3, 2024
Tweak successor lowering / filter out debug instructions from AOT IR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes FPU register moves/comparisons for MIPS1/2/3 targets. Currently,
rustcby way of LLVM generates broken code for themipsel-sony-psptarget when using Rust-PSP. The LLVM patch goes over the details.