[rust] Mark inlined calls to functions in same SCC as callee as noinline #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the catastrophic inlining issues observerd with the new LLVM pass manager. Patch by Arthur Eubanks from https://reviews.llvm.org/D120584.
|
r=me. We can undo it later if needed. This fixes critical issues and the only concern upstream seems to be related to runtime performance hit in nobody knows what test cases really. |
|
I'll hold off on this for a bit longer, as it looks like we might get an upstream consensus after all. |
|
Okay, we ended up going with https://reviews.llvm.org/D121084 upstream. I've merged the release branch and put up rust-lang/rust#94764. |
vext01
pushed a commit
to vext01/llvm-project
that referenced
this pull request
Apr 19, 2024
Serialise the new "statically typed" AOT IR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the catastrophic inlining issues observed with the new LLVM pass manager. Patch by Arthur Eubanks from https://reviews.llvm.org/D120584.
I had really hoped that we could get this fixed upstream first, but I don't think we can justify waiting any longer here. Upstream maintainers have been blocking patches for this issue for a year now, because they prioritize possible performance impact over a working compiler.
As far as rustc is concerned, this patch is performance-neutral: https://perf.rust-lang.org/compare.html?start=f0c4da49983aa699f715caf681e3154b445fb60b&end=2ee65d3199ddf4ad731e05c7a17a6ccf5becc565