Skip to content

[llvm-config] cherrypick llvm#93754 #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

khuey
Copy link

@khuey khuey commented Jun 26, 2024

Cherry pick llvm#93754 to unblock rust-lang/rust#125642

llvm#93754)

LLVM's build system does the right thing but LLVM_SYSTEM_LIBS ends up
containing the shared library. Emit the static library instead when
appropriate.

With LLVM_USE_STATIC_ZSTD, before:

khuey@zhadum:~/dev/llvm-project/build$ ./bin/llvm-config --system-libs
-lrt -ldl -lm -lz -lzstd -lxml2

after:

khuey@zhadum:~/dev/llvm-project/build$ ./bin/llvm-config --system-libs
-lrt -ldl -lm -lz /usr/local/lib/libzstd.a -lxml2

(cherry-picked from 0f24a46)
@dianqk dianqk requested a review from nikic June 26, 2024 21:14
vext01 pushed a commit to vext01/llvm-project that referenced this pull request Jun 28, 2024
@nikic nikic merged commit e6a6470 into rust-lang:rustc/18.1-2024-05-19 Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants