Skip to content
This repository was archived by the owner on Feb 5, 2019. It is now read-only.

Add certain jemalloc functions to MemoryBuiltins #37

Merged
merged 1 commit into from
Feb 17, 2015

Conversation

XMPPwocky
Copy link

This informs LLVM that they return noalias pointers, and allows "dead" allocations to be optimized out.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@huonw
Copy link
Member

huonw commented Feb 17, 2015

Hm, it's unclear to me how many special-cased optimisations we want for Rust. Thoughts, @alexcrichton?

@alexcrichton alexcrichton merged commit 2d34bef into rust-lang:rust-llvm-2015-02-13 Feb 17, 2015
@alexcrichton
Copy link
Member

I don't think we want to go crazy over time or rely on these optimizations being available, but we already have another optimization (the NullCheckElimination pass) and it seems fine to include this. Patches that don't hinder reliance on upstream or stock LLVM seem fine to me in general.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants