Allow #[macro_use(info)] to import individual macros.
#220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inline logic from `log!` into `error!`/`warn!`/`...`. Alternatively, we could create a helper function which all macros call (passing in the output of `file!`/`line!`/etc.), but this helper function would need to be in the public API of `log`, which is a bit ugly. Fixes #54.
|
Looking at the proposal in #218, it may be that the macros will soon become more complex, making the code duplication a lot more painful... |
|
Thanks for doing this @mjkillough! My personal feeling on this is that we should hold off for now, assuming we want to solve this problem this way, so there's less friction to exploring structured logging. @sfackler might have other ideas though. |
|
Yeah, I'd be a bit worried about the implementations desynchronizing, especially as the macros become more complicated. Making a script to generate the module is one option. |
|
Yep, that's fair enough! I'll close this one. |
EFanZh
pushed a commit
to EFanZh/log
that referenced
this pull request
Jul 23, 2023
Forbid --manifest-path to used with batch installation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inline logic from
log!intoerror!/warn!/....Alternatively, we could create a helper function which all macros call (passing in the output of
file!/line!/etc.), but this helper function would need to be in the public API oflog, which is a bit ugly.After playing around with alternatives, I figured I may as well open a PR for this option (which I consider to be the least of all evils). If the duplication is undesirable, then feel free to close! :)
Fixes #54.