Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize logging codegen #276

Merged
merged 1 commit into from
Jun 5, 2018
Merged

Optimize logging codegen #276

merged 1 commit into from
Jun 5, 2018

Commits on Jun 3, 2018

  1. Optimize logging codegen

    The extra work involved in loading the logger and creating the record
    struct involves move codegen than is necessary if we take this kind of
    approach (which we previously used in 0.3). It's a bit unfortunate to
    have these public-but-not-public functions, but I think it's worth it.
    We want to minimize the footprint of logging so people feel comfortable
    using it!
    
    A main function containing nothing but `warn!("hello world")` shrinks
    from 204 bytes to 124 bytes in x86_64 with this change.
    
    Closes rust-lang#275
    sfackler committed Jun 3, 2018
    Configuration menu
    Copy the full SHA
    8ca698f View commit details
    Browse the repository at this point in the history