Skip to content

Update format_args! usage to work with current version of Rust #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update format_args! usage to work with current version of Rust #4

wants to merge 1 commit into from

Conversation

fhahn
Copy link

@fhahn fhahn commented Dec 29, 2014

No description provided.

@japaric
Copy link
Member

japaric commented Dec 29, 2014

r? @alexcrichton / @eddyb

@eddyb
Copy link
Member

eddyb commented Dec 29, 2014

@fhahn see the fallout in the copy of log in rust-lang/rust - prefer passing by value. Then again, I don't care too much, if this works.
I don't have permissions for this repo, so @alexcrichton or someone else would have to merge.

@fhahn
Copy link
Author

fhahn commented Dec 29, 2014

@eddyb do you mean passing fmt::Arguments by value to pub fn log(level: u32, loc: &'static LogLocation, args: &fmt::Arguments)?

@alexcrichton
Copy link
Member

Thanks! The changes in the main repo are reflected more in #5, so I'm gonna just merge that instead.

EFanZh pushed a commit to EFanZh/log that referenced this pull request Jul 23, 2023
@passcod
QuickInstall support (rust-lang#94)
370ae05 
See this issue: cargo-bins/cargo-quickinstall#27

Quick Install is a hosted repo of built crates, essentially. The approach I've taken here is
a list of strategies:

1. First, we check the crate meta or default and build the URL to the repo. Once we have
   that, we perform a `HEAD` request to the URL to see if it's available.
2. If it's not, we build the URL to the quickinstall repo, and perform a `HEAD` to there.

As soon as we've got a hit, we use that. I've built it so it's extensible with more strategies.
This could be useful for rust-lang#4.

This also adds a prompt before downloading from third-party sources, and logs a short
name for a source, which is easier to glance than a full URL, and includes a quick refactor
of the install/link machinery.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fhahn @japaric @eddyb @alexcrichton