Remove the __private_api_log_lit
special case
#446
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#445 (comment):
Closes #445.
I did not add a test for
format_args_capture
. I think I need to create a custom logger to capture records and add a testing-only crate feature or--cfg
(to tell if#![feature(format_args_capture)]
is allowed to use) to test it.format_args_capture
is unstable now, I'm not sure if it worths it. Feel free to ask me to add such test if it's necessary.