Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#487 Add thumbv4t-none-eabi to the list of targets that don't support… #488

Merged
merged 2 commits into from
Mar 2, 2022
Merged

Conversation

wtetzner
Copy link
Contributor

Add thumbv4t-none-eabi to the list of targets that don't support atomics.

With this change, it builds fine for thumbv4t-none-eabi.

Without this change, I get a build failure for thumbv4t-none-eabi:

    Blocking waiting for file lock on package cache
    Updating crates.io index
    Blocking waiting for file lock on package cache
   Compiling log v0.4.14
   Compiling cfg-if v1.0.0
error[E0599]: no method named `compare_exchange` found for struct `AtomicUsize` in the current scope
    --> /Users/walter/.cargo/registry/src/github.com-1ecc6299db9ec823/log-0.4.14/src/lib.rs:1347:33
     |
1347 |     let old_state = match STATE.compare_exchange(
     |                                 ^^^^^^^^^^^^^^^^ method not found in `AtomicUsize`

For more information about this error, try `rustc --explain E0599`.
error: could not compile `log` due to previous error

Copy link
Contributor

@KodrAus KodrAus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wtetzner!

@KodrAus KodrAus merged commit d672066 into rust-lang:master Mar 2, 2022
EFanZh pushed a commit to EFanZh/log that referenced this pull request Jul 23, 2023
Fixed rust-lang#485

* Make `Duration` in MainExit::Success` optional
* Fix arg parsing: Print version on `-V`

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants