Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the log crate instead of the home-made macros #151

Closed
azerupi opened this issue Jul 8, 2016 · 0 comments
Closed

Use the log crate instead of the home-made macros #151

azerupi opened this issue Jul 8, 2016 · 0 comments

Comments

@azerupi
Copy link
Contributor

azerupi commented Jul 8, 2016

The log crate provides macros like debug!, info!, trace!, etc. There is no need to recreate this in mdBook.

Another advantage of using the log crate is that the final behavior of the logging macros is defined by the binary. If mdBook were to be used as a lib, the user could choose how the logging reports the information.
@azerupi azerupi added this to the 0.1.0 milestone Aug 12, 2016
azerupi added a commit that referenced this issue Aug 14, 2016
@azerupi
Merge pull request #164 from gambhiro/use-log-crate
8f8893b 
use macros from the log crate, issue #151
@azerupi azerupi closed this as completed Aug 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@azerupi