Skip to content

Conversation

japaric
Copy link

@japaric japaric commented Mar 7, 2016

This one is more complex. I hope I got it right on the first try. crosses fingers


after_success:
- test $TRAVIS_PULL_REQUEST == "false" && test $TRAVIS_BRANCH == "master" && bash deploy.sh
- test $TRAVIS_PULL_REQUEST == "false" &&
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope this right, this is meant to:

  • run on a single build job, and
  • the npm install stylus nib is only needed for this deploy script

?

@japaric
Copy link
Author

japaric commented Mar 7, 2016

Argh, about the Travis errors. doctests are known to not work correctly when --target is used with cargo test. Let me think about how to workaround this problem.

@japaric
Copy link
Author

japaric commented Mar 8, 2016

Fixed the doc test problem, but we now have a legit failure. The notify crate can't be correctly compiled for i686-apple-darwin because its fsevent{,-sys} dependencies aren't compiled for that target (see 1, note that i686-apple-darwin is missing). I propose not targeting i686-apple-darwin until that is sorted out.

@japaric
Copy link
Author

japaric commented Mar 8, 2016

All Travis CI tests are green. @azerupi r?

@japaric japaric mentioned this pull request Mar 8, 2016
21 tasks
@azerupi
Copy link
Contributor

azerupi commented Mar 8, 2016

I propose not targeting i686-apple-darwin until that is sorted out.

I suppose that is acceptable, 32-bits Macs are quite old.. There shouldn't be too much of them (I think) 😋

I will merge when I get home

azerupi added a commit that referenced this pull request Mar 8, 2016
Travis CI: expand to test and deploy for Linux and Mac
@azerupi azerupi merged commit 6bac41c into rust-lang:master Mar 8, 2016
@azerupi
Copy link
Contributor

azerupi commented Mar 8, 2016

Merged, I will push a new release to test it :)

@japaric japaric deleted the travis branch March 8, 2016 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants