fontawesome upgrade to 5.13; incl free brand solid #1225
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add page title override: {{#title My Title}}
* Document {{#title}} in guide
Includes new configuration option `git-repository-edit-baseurl` for supporting non-GitHub repository layouts.
…dependent of git_repository_url.
|
Hey :) Just stumbled upon the issue that the bundled font awesome lib is still version Or rather, is there even an official interest in bumping the font awesome version? |
|
☔ The latest upstream changes (possibly #2681) made this pull request unmergeable. Please resolve the merge conflicts. |
rustbot
added
the
S-waiting-on-author
|
I'm going to close as handling of font-awesome has switch to a different approach in #1330. Thanks for the PR, though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Straightforward and tested.
However, for backwards compatibility, there are at least two options. At the moment, the upgrade breaks old
index.hbsfiles - which is somewhat unnecessary. These oldindex.hbsare encouraged to be kept as theme overrides and - only if that is the case - would have to be updated manually.The reason is simply that FontAwesome changed their filename from
font-awesome.csstofontawesome.csswithout the hyphen. The files are rewritten anyways, thusfont-awesome.cssfont-awesome.cssandfontawesome.cssThe new way to write would cause less confusion in the long run, being consistent with FontAwesome's naming.