Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collect all test failures before failing #1313

Merged
merged 2 commits into from
Sep 6, 2020
Merged

Conversation

guswynn
Copy link
Contributor

@guswynn guswynn commented Sep 4, 2020

I found that iterating on mdbook test is fairly slow as any failure in any file halts the process
This prints the error with error~, marks a failure, and then moves on

I tested that the return code is 0 on a passing book (i had a working local version of the cargo book) and that its non-0 on a non-passing book (dummy_book in tests is good for this)

Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have kinda wanted this in the past, too. I made a small wording change, which looked like maybe a typo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants