Skip to content

Add hidelines code class to enable hiding in non-Rust blocks #1379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add hidelines code class to enable hiding in non-Rust blocks #1379

wants to merge 1 commit into from

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Nov 12, 2020

```toml,hidelines

Screenshot from 2020-11-11 22-49-31

Screenshot from 2020-11-11 22-49-44

@dtolnay
Copy link
Member Author

dtolnay commented Nov 12, 2020

Possible future extension: ```language,hidelines=@ for hiding based on a symbol other than #.

@dtolnay dtolnay mentioned this pull request Nov 14, 2020
Merged
@ehuss
Copy link
Contributor

ehuss commented Nov 15, 2020

Just a heads up, there's another PR for something similar: #1339.

I won't have time to do reviews for a little while, but if you could maybe take a look at that PR and give feedback on the design? I'm a bit uncertain on how to approach this, but on the surface that PR seems to be fairly flexible.

@dtolnay
Copy link
Member Author

dtolnay commented Nov 15, 2020

I definitely don't like that approach. 😕 Left a comment.

@dtolnay
Copy link
Member Author

dtolnay commented Sep 23, 2023

Superseded by #2093!

@dtolnay dtolnay closed this Sep 23, 2023
@dtolnay dtolnay deleted the hidelines branch September 23, 2023 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dtolnay @ehuss