Use light theme when javascript is disabled #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdBook is setting theme (by adding a class attribute to body tag) with javascript. Page is not using any theme by default and page is not using any styling unless javascript is enabled. This patch is adding class attribute to body tag and making mdBook to use `light` theme when javascript is disabled. Fixes: #144
|
Hah thanks! 😄 |
|
Awesome! That was a big issue for me, I thought it was a design choice and never reported the issue 😶 |
|
I encourage you to report things you think could be better. 😊 Specifically, fully supporting no-JS browsers is not an absolute goal. But if they can be supported without resorting to ugly hacks or added complexity, it's definitely something I want to do. And if it's too much trouble it should at least degrade gracefully when possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mdBook is setting theme (by adding a class attribute to body tag) with javascript.
Page is not using any theme by default and page is not using any styling unless
javascript is enabled.
This patch is adding class attribute to body tag and making mdBook to use
lighttheme when javascript is disabled.
Fixes: #144