Make print page (print.html) links link to anchors on the print page

[HollowMan6]

Resolves #1736

Let all the anchors id on the print page to have a path id prefix to
help locate.

e.g. bar/foo.md#abc -> #bar-foo-abc

Also append a dummy div to the start of the original page to make sure
that original page links without an anchor can also be located.

Signed-off-by: Hollow Man hollowman@opensuse.org

[HollowMan6]

Tested on the following Rust Bookshelf books with the js code here checking broken links also unavailable anchors on print.html.

With this PR now all the links on the print page are self-contained, no broken links found except for those who are broken originally, or has self-made JavaScript that needs adaptation (ferris.js in Rust Programming Language).

Title	Source	Original Book Online Version
Cargo Book	Source	HTML
Edition Guide	Source	HTML
Embedded Rust Book	Source	HTML
Mdbook User Guide	Source	HTML
Rust Reference	Source	HTML
Rust By Example	Source	HTML
Rust Programming Language	Source	HTML
Rustc Book	Source	HTML
Rustdoc Book	Source	HTML
Rustonomicon	Source	HTML

Please review, Will appreciate if this PR can be merged.

cc: @ehuss

[dyaso]

This was very helpful for me, it would be nice if this could be merged so i didn't have to build HollowMan6's fork myself in order to generate PDFs whose internal links work

[HollowMan6]

Hi @ehuss , I've noticed that you added the S-waiting-on-author label to this PR recently, but I can't see any code change requests and even reviews for this PR. Am I missing something and what should I response/clarify?

[ehuss]

This is just a partial review, there are some other things that I'd like to follow up on.

[ehuss]

but I can't see any code change requests and even reviews for this PR. Am I missing something and what should I response/clarify?

I'm so sorry. I had a partial review that I wrote a long time ago, but never finished and didn't click the submit button. But GitHub displays the review on the conversation page as-if it was submitted (with a little icon that I overlooked), so I thought I had submitted it.

[HollowMan6]

This is just a partial review, there are some other things that I'd like to follow up on.

Done! Thanks for reviewing. Would love to see it get merged in the near future.

[ehuss]

I appreciate your patience here. In #2844 we've taken a different approach to how HTML is processed. As part of that process, I have updated the print page to now have all anchor links. If you'd like, it would be helpful if you can give it a try and let me know how it works for you.

[rustbot]

☔ The latest upstream changes (possibly 1c034bd) made this pull request unmergeable. Please resolve the merge conflicts.

[HollowMan6]

Hi @ehuss! Thank you for supporting this and relieving my pain from resolving the conflicts. I tested several books with the mdbook-pdf CI/CD, and I think your changes look good, though they break the code at my side for generating the ToC from mdbook for PDFs, as it relies on the path ID prefix to locate anchors in print.html, and I can't come up with a better solution for supporting it, so probably I will mark this feature as deprecated and continue with the wkhtmltopdf style ToC.

I'll close this now and revert my changes back to v0.4.52 for backward compatibility.