Skip to content

Conversation

virtualritz
Copy link

See #1936.

  • Renamed config.curly-quotes to config.smart-punctuation.
  • Ran rustfmt.
  • Made line length consistently 80 characters in renderer.md.

@rustbot rustbot added the S-waiting-on-review Status: waiting on a review label Jan 2, 2024
@ehuss
Copy link
Contributor

ehuss commented Jan 2, 2024

Hi! Thanks for the PR!

Can you drop the commit that re-wraps the file? I have been moving things in the opposite direction to instead use semantic line breaks which can make it easier to review changes.

Also, can you keep the original curly_quotes field, and emit a warning that it is deprecated and tell the user what the new field name is?

Finally, can you add a test to rendered_output.rs to verify the behavior when the value is and isn't set?

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. and removed S-waiting-on-review Status: waiting on a review labels Jan 2, 2024
@virtualritz
Copy link
Author

Will do, but I will have to find some time for this.

@ehuss
Copy link
Contributor

ehuss commented Feb 25, 2024

I've pushed PR #2327 to move this forward. Thanks!

@ehuss ehuss closed this Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants