Revert update to pulldown-cmark 0.11 #2386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cmark" This reverts commit 8884008, (rust-lang#2381) reversing changes made to 3d6caa5. The `pulldown_cmark` types are a public API, which I did not realize.
tanishiking
added a commit
to tanishiking/jco
that referenced
this pull request
Apr 2, 2025
The `|` was not rendering correctly inside code blocks within tables when processed by `mdbook`. rust-lang/mdBook#637 Idealy, this should be addressed by the upstream. The root cause of this problem in `pulldown-cmark` has recently been fixed. pulldown-cmark/pulldown-cmark#356 However, `mdbook` seems to expose the `pulldown-cmark` types as a public API, and is currently facing difficulties updating its dependencies. rust-lang/mdBook#2386 Therefore, the upstream fix may not available in any time soon. As a workaround for the time being, use <code> tag instead of code blocks in tables with `|`.
vados-cosmonic
pushed a commit
to bytecodealliance/jco
that referenced
this pull request
Apr 2, 2025
The `|` was not rendering correctly inside code blocks within tables when processed by `mdbook`. rust-lang/mdBook#637 Idealy, this should be addressed by the upstream. The root cause of this problem in `pulldown-cmark` has recently been fixed. pulldown-cmark/pulldown-cmark#356 However, `mdbook` seems to expose the `pulldown-cmark` types as a public API, and is currently facing difficulties updating its dependencies. rust-lang/mdBook#2386 Therefore, the upstream fix may not available in any time soon. As a workaround for the time being, use <code> tag instead of code blocks in tables with `|`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 8884008, (#2381) reversing changes made to 3d6caa5.
The
pulldown_cmarktypes are a public API, which I did not realize.See #2387.