Skip to content

Add GUI regression test for #2529 #2531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Add GUI regression test for #2529 #2531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6720fc
Update browser-ui-test version to 0.19.0
GuillaumeGomez Jan 23, 2025
ce63cc3
Add GUI regression test for #2529
GuillaumeGomez Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
merge_group:

env:
BROWSER_UI_TEST_VERSION: '0.18.2'
BROWSER_UI_TEST_VERSION: '0.19.0'

jobs:
test:
Expand Down
1 change: 0 additions & 1 deletion tests/gui/runner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ fn main() {
let mut command = Command::new("npx");
command
.arg("browser-ui-test")
.arg("--no-sandbox")
.args(["--variable", "DOC_PATH", book_dir.as_str()])
.args(["--test-folder", "tests/gui"]);
if std::env::args().any(|arg| arg == "--disable-headless-test") {
Expand Down
16 changes: 16 additions & 0 deletions tests/gui/sidebar-nojs.goml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
// This GUI test checks that the sidebar takes the whole height when it's inside
// an iframe (because of JS disabled).
// Regression test for <https://github.com/rust-lang/mdBook/issues/2528>.

// We disable the requests checks because `searchindex.json` will always fail
// locally.
fail-on-request-error: false
// We disable javascript
javascript: false
go-to: |DOC_PATH| + "index.html"
store-value: (height, 1000)
set-window-size: (1000, |height|)

within-iframe: (".sidebar-iframe-outer", block {
assert-size: (" body", {"height": |height|})
})
Loading