Add error-chain throughout the codebase #361
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help with #14 (better error messages), I've included
error-chain
as a dependency and updated almost all the places we return aResult
to use the new error type instead ofBox<Error>
orstd::io::Error
.I skipped the handlebars helpers though. Handlebars expects you to return a specific error type, so you can't use the
error-chain
error type there.Now we just need to let people know to use the new error type when returning a
Result
, and that they should usechain_err()
to return an error while also attaching a human-readable explanation of what went wrong.