Skip to content

Make installation instructions stable #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
michaelwoerister opened this issue Sep 14, 2021 · 5 comments · Fixed by #189
Closed

Make installation instructions stable #182

michaelwoerister opened this issue Sep 14, 2021 · 5 comments · Fixed by #189

Comments

@michaelwoerister
Copy link
Member

#177 changed installation instructions to a specific tag which is much better than making them install whatever is on the main branch at the moment. However, it would be even better if the installation string could stay immutable regardless of what the current version is.

Now that we support old file formats too, we could introduce a "stable" branch that always points to the latest release. That would enable us to make the installation string something like:

cargo install --git https://github.com/rust-lang/measureme --branch stable crox

We could then also update the instructions in https://blog.rust-lang.org/inside-rust/2020/02/25/intro-rustc-self-profile.html, which is still a common entry point to self-profiling, I think (at least I always point folks to that).

@rylev
Copy link
Member

rylev commented Sep 14, 2021

I'd be in favor of this change. However, what speaks against just releasing all the crates in the tool suite on crates.io so that users can install with cargo install?

@michaelwoerister
Copy link
Member Author

Right, that would be an option too. The only thing that speaks against that is that the tool names are a bit too generic right now, e.g. flamegraph, stack_collapse, summarize, ... Is there a way to "namespace" the tools?

@rylev
Copy link
Member

rylev commented Sep 15, 2021

Unfortunately not - we'd have to change their names which is unfortunate... Perhaps the right long term solution is to create the metabinary, and then release that on crates.io

@martin-t
Copy link

martin-t commented Oct 4, 2021

The name flamegraph conflicts with an already existing tool - https://crates.io/crates/flamegraph. I find this confusing - i had the other tool installed (it seems installing one silently overwrites the other) and took me a while to realize what was happening.

@rylev
Copy link
Member

rylev commented Oct 7, 2021

I think the best thing to do in that case is rename the executable. Usually the executable are installed in ~/.cargo/bin so all you need to do is just change the name of the executable there. It would be nice if cargo install had an option for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants