-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce decodeme crate and start supporting old file format versions. #181
Conversation
824eb7f
to
14db1f7
Compare
14db1f7
to
972d15d
Compare
972d15d
to
5ff7e7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I did not update the installation instructions. Instead I opened #182 for discussing a more permanent solution. Otherwise I think this is ready for a final review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
of measureme might help. + rustfmt
1ae21a9
to
23ae11d
Compare
This PR splits the version-specific parts of file decoding into a separate crate called
decodeme
. This will make it easy in the future to keep supporting old file formats by makinganalyzeme
depend on multiple versions ofdecodeme
and always have it convert data to the current format.As an example, this is what the crate graph would look like for
analyzeme 17.0.0
if we want it to support a couple of older file formats.See
analyzeme/src/file_formats/v7.rs
for an example of what it looks like to implement support for an old file format.Since
decodeme
does not yet exist for v9.x, this commit will makeanalyzeme 10.0.0
depend onanalyzeme 9.2.0
.TODO:
Add test cases that make sure old fileformats still work?@rylev will take care of this in a separate PR.r? @wesleywiser & @rylev
Fixes #178