Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix big-endian build and add CI tests for it. #103

Merged
merged 3 commits into from
Jan 2, 2020

Conversation

michaelwoerister
Copy link
Member

@michaelwoerister michaelwoerister commented Jan 2, 2020

This PR

This PR should fail until the big endian specific error uncovered here is fixed.

@michaelwoerister
Copy link
Member Author

But it fails before it can even install Rust :(

@michaelwoerister michaelwoerister force-pushed the big-endian-ci branch 8 times, most recently from aa79938 to a93ebad Compare January 2, 2020 14:20
@wesleywiser
Copy link
Member

event_kind: StringId::reserved(LittleEndian::read_u32(&bytes[0..])),
event_id: StringId::reserved(LittleEndian::read_u32(&bytes[4..])),

is cfg'd out on little-endian and got broken in a prior commit. I believe these should just be StringId::new() right?

@wesleywiser wesleywiser self-assigned this Jan 2, 2020
@michaelwoerister
Copy link
Member Author

Yes, that's the error. I'm tweaking .travis.yml until it properly catches the error and then add a fix to this PR.

@wesleywiser
Copy link
Member

Oh, sorry. I didn't realize what was going on. Carry on! 🙂

@michaelwoerister michaelwoerister changed the title Add big-endian CI tests. Fix big-endian build and add CI tests for it. Jan 2, 2020
@michaelwoerister
Copy link
Member Author

Alright, ready for review :)

@wesleywiser wesleywiser merged commit e6f55c7 into rust-lang:master Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants