Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README for changes in x.py defaults #124

Merged
merged 2 commits into from
Aug 17, 2020

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Aug 16, 2020

See rust-lang/rust#73964.

The choices are either to link to stage1 with rustup or build stage 2; this recommends to build stage2 to be consistent with the existing docs.

See rust-lang/rust#73964.

The choices are either to link to `stage1` with rustup or build stage 2; this recommends to build stage2 to be consistent with the existing docs.
@@ -80,7 +80,7 @@ You can also profile your own custom build of rustc. First you'll have to clone

```bash
$ git clone https://github.com/rust-lang/rust.git
$ ./x.py build
$ ./x.py build --stage 2
# This will take a while...
$ rustup toolchain link mytoolchain build/x86_64-unknown-linux-gnu/stage2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm really stage1 should be enough; you should be comparing builds produced locally anyway.

Copy link
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wesleywiser wesleywiser merged commit aeb68ce into rust-lang:master Aug 17, 2020
@jyn514 jyn514 deleted the patch-1 branch August 17, 2020 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants