Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move vector_clock and sync into concurrency, make vector_clock private #2199

Closed
RalfJung opened this issue Jun 6, 2022 · 1 comment · Fixed by #2500 or #2504
Closed

Move vector_clock and sync into concurrency, make vector_clock private #2199

RalfJung opened this issue Jun 6, 2022 · 1 comment · Fixed by #2500 or #2504
Labels
A-concurrency Area: affects our concurrency (multi-thread) support C-cleanup Category: cleaning up our code E-good-first-issue A good way to start contributing, mentoring is available

Comments

@RalfJung
Copy link
Member

RalfJung commented Jun 6, 2022

#1963 introduces a concurrency module collecting the data race and weak memory code. If possible, it'd be nice to make vector_clock private to that module, too; that will require moving sync.rs (and maybe thread.rs) into it as well.
@RalfJung RalfJung added A-concurrency Area: affects our concurrency (multi-thread) support C-cleanup Category: cleaning up our code labels Jun 6, 2022
@RalfJung RalfJung added the E-good-first-issue A good way to start contributing, mentoring is available label Jul 1, 2022
@Hiroki6 Hiroki6 mentioned this issue Aug 21, 2022
Merged
@bors bors closed this as completed in 7b07162 Aug 21, 2022
@RalfJung
Copy link
Member Author

RalfJung commented Aug 22, 2022 •
edited
Loading

Reopening to track moving thread.rs into the concurrency module.

@RalfJung RalfJung reopened this Aug 22, 2022
@Hiroki6 Hiroki6 mentioned this issue Aug 22, 2022
Merged
@bors bors closed this as completed in 53138c6 Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-concurrency Area: affects our concurrency (multi-thread) support C-cleanup Category: cleaning up our code E-good-first-issue A good way to start contributing, mentoring is available
Projects
None yet
Milestone
No milestone
1 participant
@RalfJung