Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move vector_clock and sync into concurrency & make vector_clock private #2500

Merged
merged 2 commits into from
Aug 21, 2022
Merged

move vector_clock and sync into concurrency & make vector_clock private #2500

merged 2 commits into from
Aug 21, 2022
+14 −11

Conversation

Hiroki6
Copy link
Contributor

@Hiroki6 Hiroki6 commented Aug 21, 2022

Closes #2199

The thread.rs didn't have to be moved to build.
If it makes more sense to move the thread.rs as well, please let me know. I can move it as well.

@RalfJung
Copy link
Member

This looks good, thanks. :)
@bors r+

If it makes more sense to move the thread.rs as well, please let me know. I can move it as well.

Yes I think that would make sense. Would you like to submit a follow-up PR for that?

@bors
Copy link
Contributor

bors commented Aug 21, 2022

📌 Commit 8ee6849 has been approved by RalfJung

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Aug 21, 2022

⌛ Testing commit 8ee6849 with merge 7b07162...

@bors
Copy link
Contributor

bors commented Aug 21, 2022

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 7b07162 to master...

@bors bors merged commit 7b07162 into rust-lang:master Aug 21, 2022
@bors bors mentioned this pull request Aug 21, 2022
Merged
@Hiroki6
Copy link
Contributor Author

Hiroki6 commented Aug 22, 2022 •
edited
Loading

Yes I think that would make sense. Would you like to submit a follow-up PR for that?

Yes, I will do that.

@Hiroki6 Hiroki6 deleted the make-vector-clock-private branch August 22, 2022 09:30
@Hiroki6 Hiroki6 mentioned this pull request Aug 22, 2022
Merged
bors added a commit that referenced this pull request Aug 22, 2022
@bors
Auto merge of #2504 - Hiroki6:move-thread-to-concurrency-module, r=Ra…
53138c6 
…lfJung

move thread.rs into concurrency

Follow-up of #2500 and closes #2199

I moved the `thread.rs` into the `concurrency` module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move vector_clock and sync into concurrency, make vector_clock private
3 participants
@Hiroki6 @RalfJung @bors