Skip to content

Windows console API shims are missing #2652

Open
@thomcc

Description

@thomcc

Miri punts on GetConsoleMode currently, which means that under miri, the stdlib's stdio implementation is rather different than reality. This means several things that don't work in reality will work under miri (such as writing invalid UTF-8 to stdout), and also that the windows stdio code continues to be untested (not as worrisome as some of the sys::windows code, although it's probably the trickiest code with regards to MaybeUninit. But generally, it would be nice for us to align reality with what miri tests.

I took a look and I'm not sure how to do this really. It seems like much of windows IO is smoke and mirrors. So this almost certainly requires implementing a few other calls as well, such as WriteConsoleW and the like, although I think you can just implement console coloring as a no-op for now.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-shimsArea: This affects the external function shimsA-windowsArea: affects only Windows targetsC-enhancementCategory: a PR with an enhancement or an issue tracking an accepted enhancement

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions