Skip to content

Check for required target features when evaluating LLVM intrinsics #3178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eduardosm opened this issue Nov 19, 2023 · 0 comments · Fixed by #3180
Closed

Check for required target features when evaluating LLVM intrinsics #3178

eduardosm opened this issue Nov 19, 2023 · 0 comments · Fixed by #3180

Comments

@eduardosm
Copy link
Contributor

Many LLVM intrinsics require some target features (e.g., llvm.x86.sse.* intrinsics generally require the x86 SSE feature)-

We are not currently checking whether they are enabled or not, since intrinsics are not defined with a #[target_feature(enable = "...")] attribute.

Noticed in #3176 (comment).
This was referenced Nov 19, 2023
Merged
Merged
@bors bors closed this as completed in cad4f40 Nov 22, 2023
RalfJung pushed a commit to RalfJung/rust that referenced this issue Nov 25, 2023
@bors
Auto merge of rust-lang#3180 - eduardosm:check-intrinsics-target-feat…
faed7c5 
…ure, r=RalfJung

Check that target features required by LLVM intrinsics are enabled

Fixes rust-lang/miri#3178
RalfJung pushed a commit to RalfJung/rust that referenced this issue Nov 25, 2023
@bors
Auto merge of rust-lang#3180 - eduardosm:check-intrinsics-target-feat…
41d7012 
…ure, r=RalfJung

Check that target features required by LLVM intrinsics are enabled

Fixes rust-lang/miri#3178
lnicola pushed a commit to lnicola/rust-analyzer that referenced this issue Apr 7, 2024
@bors
Auto merge of rust-lang#3180 - eduardosm:check-intrinsics-target-feat…
12b8af9 
…ure, r=RalfJung

Check that target features required by LLVM intrinsics are enabled

Fixes rust-lang/miri#3178
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this issue Apr 27, 2024
@bors
Auto merge of rust-lang#3180 - eduardosm:check-intrinsics-target-feat…
8d5cc53 
…ure, r=RalfJung

Check that target features required by LLVM intrinsics are enabled

Fixes rust-lang/miri#3178
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check that target features required by LLVM intrinsics are enabled
1 participant
@eduardosm