Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add direct tests for the Windows RNG functions #3308

Closed
RalfJung opened this issue Feb 21, 2024 · 2 comments · Fixed by #3309 or #3326
Closed

Add direct tests for the Windows RNG functions #3308

RalfJung opened this issue Feb 21, 2024 · 2 comments · Fixed by #3309 or #3326

Comments

@RalfJung
Copy link
Member

Once rust-lang/rust#121337 lands we'll support 3 RNG functions on Windows. I don't know which of these we are testing at all, since we're only testing them indirectly via std and getrandom. Would be good to have a test that calls them directly, just to make sure that they remain covered.

@ChrisDenton if you could help write such a test that would be great. :)

@ChrisDenton
Copy link
Member

I don't really know miri that well but sure I can throw up some some code.

@RalfJung
Copy link
Member Author

Reopening since we should add a test for ProcessPrng once rust-lang/rust#121337 lands.

@RalfJung RalfJung reopened this Feb 21, 2024
bors added a commit that referenced this issue Feb 26, 2024
@bors bors closed this as completed in 456c69e Feb 26, 2024
RalfJung pushed a commit to RalfJung/rust that referenced this issue Mar 3, 2024
lnicola pushed a commit to lnicola/rust-analyzer that referenced this issue Apr 7, 2024
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this issue Apr 27, 2024
spikespaz pushed a commit to spikespaz/dotwalk-rs that referenced this issue Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants