Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check atomic access alignment requirements #475

Closed
RalfJung opened this issue Oct 12, 2018 · 0 comments · Fixed by #876
Closed

Check atomic access alignment requirements #475

RalfJung opened this issue Oct 12, 2018 · 0 comments · Fixed by #876
Labels
A-validation Area: This affects enforcing the validity invariant, and related UB checking C-bug Category: This is a bug. I-misses-UB Impact: makes Miri miss UB, i.e., a false negative (with default settings)

Comments

@RalfJung
Copy link
Member

As pointed out in rust-lang/rust#53514, atomic accesses have higher alignment requirements than normal accesses. We should model this properly in miri.
@oli-obk oli-obk added C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement needs-test labels Oct 12, 2018
@RalfJung RalfJung added C-bug Category: This is a bug. and removed C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement labels Nov 17, 2018
@RalfJung RalfJung added the A-validation Area: This affects enforcing the validity invariant, and related UB checking label Mar 8, 2019
@RalfJung RalfJung mentioned this issue Aug 2, 2019
Merged
@RalfJung RalfJung added the I-misses-UB Impact: makes Miri miss UB, i.e., a false negative (with default settings) label Aug 3, 2019
bors added a commit that referenced this issue Aug 4, 2019
@bors
Auto merge of #876 - RalfJung:atomic, r=RalfJung
ed30152 
check that atomics are sufficiently aligned

Fixes #475
@bors bors closed this as completed in #876 Aug 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-validation Area: This affects enforcing the validity invariant, and related UB checking C-bug Category: This is a bug. I-misses-UB Impact: makes Miri miss UB, i.e., a false negative (with default settings)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

check that atomics are sufficiently aligned RalfJung/miri
2 participants
@RalfJung @oli-obk