cleanup now that borrow checker knows memory is a field #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ |
|
📌 Commit 5481afb has been approved by |
bors
added a commit
that referenced
this pull request
Oct 18, 2019
cleanup now that borrow checker knows memory is a field @christianpoveda you said, I think, that `fs.rs` could also be cleaned up to longer remove-and-then-add file descriptors from the table? Could you make a PR for that?
|
💔 Test failed - checks-travis |
|
macOS timeout. @bors retry |
bors
added a commit
that referenced
this pull request
Oct 18, 2019
cleanup now that borrow checker knows memory is a field @christianpoveda you said, I think, that `fs.rs` could also be cleaned up to longer remove-and-then-add file descriptors from the table? Could you make a PR for that?
|
💔 Test failed - checks-travis |
|
Well, that looks like a partial Travis outage. I guess all we can do is wait. |
|
Sure, I'll do it when this lands |
|
@bors retry Let's see... |
bors
added a commit
that referenced
this pull request
Oct 18, 2019
cleanup now that borrow checker knows memory is a field @christianpoveda you said, I think, that `fs.rs` could also be cleaned up to longer remove-and-then-add file descriptors from the table? Could you make a PR for that?
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@christianpoveda you said, I think, that
fs.rscould also be cleaned up to longer remove-and-then-add file descriptors from the table? Could you make a PR for that?