Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory reachable through globals is not a leak #1301

Merged
merged 2 commits into from
Apr 7, 2020

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Apr 4, 2020

Blocked on rust-lang/rust#70762
Fixes #940

@RalfJung RalfJung added the S-blocked-on-rust Status: Blocked on landing a Rust PR label Apr 4, 2020
Centril added a commit to Centril/rust that referenced this pull request Apr 7, 2020
Miri leak check: memory reachable through globals is not leaked

Also make Miri memory dump prettier by sharing more code with MIR dumping, and fix a bug where the Miri memory dump would print some allocations twice.

r? @oli-obk

Miri PR: rust-lang/miri#1301
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 7, 2020
Miri leak check: memory reachable through globals is not leaked

Also make Miri memory dump prettier by sharing more code with MIR dumping, and fix a bug where the Miri memory dump would print some allocations twice.

r? @oli-obk

Miri PR: rust-lang/miri#1301
@RalfJung
Copy link
Member Author

RalfJung commented Apr 7, 2020

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 7, 2020

📌 Commit 7841f44 has been approved by RalfJung

@bors
Copy link
Collaborator

bors commented Apr 7, 2020

⌛ Testing commit 7841f44 with merge 325682a...

@bors
Copy link
Collaborator

bors commented Apr 7, 2020

☀️ Test successful - checks-travis, status-appveyor
Approved by: RalfJung
Pushing 325682a to master...

@bors bors merged commit 325682a into rust-lang:master Apr 7, 2020
@RalfJung RalfJung deleted the global-leaks branch April 7, 2020 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-blocked-on-rust Status: Blocked on landing a Rust PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

don't report memory leaks for static data
2 participants