Synchronization primitive cleanup #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eue with (un)block; comments
… on some platforms)
RalfJung
commented
May 30, 2020
|
|
||
| if this.rwlock_reader_unlock(id, active_thread) { | ||
| // The thread was a reader. | ||
| if this.rwlock_is_locked(id) { | ||
| if this.rwlock_is_locked(id).not() { |
There was a problem hiding this comment.
@vakaras there was a crucial negation missing here. I added a testcase as well to ensure that with the negation, it does the right thing.
There was a problem hiding this comment.
Thank you for catching and fixing this!
vakaras
approved these changes
May 31, 2020
|
|
||
| if this.rwlock_reader_unlock(id, active_thread) { | ||
| // The thread was a reader. | ||
| if this.rwlock_is_locked(id) { | ||
| if this.rwlock_is_locked(id).not() { |
There was a problem hiding this comment.
Thank you for catching and fixing this!
|
@bors r+ |
|
📌 Commit 0b6ec57 has been approved by |
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make some methods infallible, move a bit more work into the platform-independent
sync.rs, and fix a bug in rwlock unlocking.