Implement dup and close for stdin/stdout/stderr #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
reviewed
Aug 16, 2020
RalfJung
reviewed
Aug 16, 2020
RalfJung
reviewed
Aug 16, 2020
RalfJung
reviewed
Aug 16, 2020
RalfJung
reviewed
Aug 16, 2020
RalfJung
reviewed
Aug 16, 2020
RalfJung
reviewed
Aug 16, 2020
5 tasks
|
@samrat what is the status of this? Trying to make sure it does not get lost. :) |
|
@RalfJung I'll try to address the comments on the PR sometime this weekend. Sorry for having been a bit laggy with follow-ups on this issue(and the last :/ ) |
|
It's okay, delays happen. :) I just want to make sure this doesn't get lost. |
samrat
force-pushed
the
more-fd-trait-ops
branch
from
cf0e1e0 to
9addda3
Compare
RalfJung
reviewed
Sep 7, 2020
RalfJung
reviewed
Sep 7, 2020
RalfJung
reviewed
Sep 7, 2020
RalfJung
reviewed
Sep 7, 2020
RalfJung
reviewed
Sep 9, 2020
RalfJung
reviewed
Sep 9, 2020
RalfJung
reviewed
Sep 9, 2020
RalfJung
reviewed
Sep 9, 2020
RalfJung
reviewed
Sep 9, 2020
RalfJung
reviewed
Sep 9, 2020
RalfJung
approved these changes
Sep 9, 2020
src/shims/posix/fs.rs
Outdated
| Ok(0) | ||
| } | ||
| let result = file_descriptor.close(this.machine.communicate)?; | ||
|
|
samrat
force-pushed
the
more-fd-trait-ops
branch
from
570eef9 to
d4538af
Compare
|
Removed the newline and squashed all commits into one. |
|
@bors r+ |
|
📌 Commit d4538af has been approved by |
bors
added a commit
that referenced
this pull request
Sep 9, 2020
Implement dup and close for stdin/stdout/stderr Implements some of the operations for stdin/out/err, towards #1499
|
💔 Test failed - checks-travis |
RalfJung
reviewed
Sep 9, 2020
|
|
||
| fn main() { | ||
| unsafe { | ||
| libc::close(1); //~ ERROR stdout cannot be closed(not supported by Rust) |
There was a problem hiding this comment.
Ah, the error message here is still wrong.
(Please squash that fix.)
Support F_DUPFD on stdin/stdout/stderr Enable `close`-ing stdin/stdout/stderr For `dup`, check if FD is `File` first If not, clone the appropriate standard IO stream Merge POSIX `close` and `dup` tests into same module Also, add assertion that `write` on a closed FD returns an error. Add `dup` as FileDescriptor trait fn Also: - Fix `close` so it drops `self` instead of reference to it - Remove FD clamping in insert_fd_with_min_fd, since FDs 0-2 can be closed Fix fs_libc tests Make error message when closing stdin/out/err more specific Return io::Result from `FileDescriptor::dup` Change error message when closing stdin/out/err Refactor `FileDescriptor::dup` impl for `FileHandle` Remove empty line
samrat
force-pushed
the
more-fd-trait-ops
branch
from
d4538af to
563fb8e
Compare
|
@bors r+ |
|
📌 Commit 563fb8e has been approved by |
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements some of the operations for stdin/out/err, towards #1499