Skip to content

Remove non-power-of-two SIMD vectors #1703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 9, 2021
Merged

Remove non-power-of-two SIMD vectors #1703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd81fb3
Remove non-power-of-two SIMD vectors
calebzulawski Feb 8, 2021
053124a
Update rust-version
calebzulawski Feb 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rust-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
6a388dcfbb07b3ca3d4ad3fd3902ac7e3b11b5f6
bb587b1a1737738658d2eaecd4c8c1cab555257a
6 changes: 0 additions & 6 deletions tests/run-pass/simd-intrinsic-generic-elements.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@ struct i32x2(i32, i32);
#[repr(simd)]
#[derive(Copy, Clone, Debug, PartialEq)]
#[allow(non_camel_case_types)]
struct i32x3(i32, i32, i32);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we may need to reintroduce this (at least I was told in rust-lang/rust#27731 (comment) that we need to support these again). So we should probably have an issue that reminds us to re-add this once it works again

#[repr(simd)]
#[derive(Copy, Clone, Debug, PartialEq)]
#[allow(non_camel_case_types)]
struct i32x4(i32, i32, i32, i32);
#[repr(simd)]
#[derive(Copy, Clone, Debug, PartialEq)]
Expand All @@ -20,12 +16,10 @@ struct i32x8(i32, i32, i32, i32,

fn main() {
let _x2 = i32x2(20, 21);
let _x3 = i32x3(30, 31, 32);
let _x4 = i32x4(40, 41, 42, 43);
let _x8 = i32x8(80, 81, 82, 83, 84, 85, 86, 87);

let _y2 = i32x2(120, 121);
let _y3 = i32x3(130, 131, 132);
let _y4 = i32x4(140, 141, 142, 143);
let _y8 = i32x8(180, 181, 182, 183, 184, 185, 186, 187);

Expand Down