show proper error when using a sysroot without MIR #1856
Conversation
| @@ -132,8 +132,6 @@ pub fn report_error<'tcx, 'mir>( | |||
| }; | |||
| #[rustfmt::skip] | |||
| let helps = match e.kind() { | |||
| Unsupported(UnsupportedOpInfo::NoMirFor(..)) => | |||
There was a problem hiding this comment.
This error is never raised by Miri anyway, and I will try to remove this error variant from rustc.
|
@bors r+ |
|
📌 Commit 46d31f9 has been approved by |
|
☀️ Test successful - checks-actions |
|
@oli-obk I should probably have waited instead of landing this myself... sorry for that. I can rework this to a different approach if you'd prefer that. (The alternative is to have a query that returns |
|
ICEing is fine by me, I see no use case for handling it gently right now |
|
Well the usecase would be that we'd not have to use this hack of checking a sentinel function; instead we'd try to load the MIR on each function call and then throw a proper interpreter error when it is missing. |
Fixes #1834