Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Lrc instead of Rc in MiriCompilerCalls::config() #1863

Merged
merged 1 commit into from Jul 30, 2021
Merged

Use Lrc instead of Rc in MiriCompilerCalls::config() #1863

merged 1 commit into from Jul 30, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jul 30, 2021

The used_crate_source query defines its return type as Lrc<CrateSource>, which would be Arc when parallel-compiler = true.

I assume this fixes rust-lang/rust#87623. I didn't test that locally -- I'm not interested in parallel-compiler = true enough to be willing to recompile rustc with that configuration to test it, but I'm submitting this in case it might be useful for parallel-compiler = true users.

@RalfJung
Copy link
Member

Thanks. :)
@bors r+

@bors
Copy link
Contributor

bors commented Jul 30, 2021

📌 Commit a789b49 has been approved by RalfJung

@bors
Copy link
Contributor

bors commented Jul 30, 2021

⌛ Testing commit a789b49 with merge 1f969da...

@bors
Copy link
Contributor

bors commented Jul 30, 2021

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 1f969da to master...

@bors bors merged commit 1f969da into rust-lang:master Jul 30, 2021
@ghost ghost deleted the parallel-compiler branch August 15, 2021 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.54.0 compilation fault with nightly, miri and parallel-compiler
2 participants