Allow varargs for libc::open when it is allowed by the second argument #1970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One concern I have is with the tests, is |
|
Thanks a lot for the PR! Just as a heads-up, I am busy with job interviews for probably at least another month, so it will be a while until I will be able to review this PR. |
asquared31415
force-pushed
the
open_unix_varargs
branch
from
4ab1dad to
f549035
Compare
RalfJung
reviewed
Feb 20, 2022
RalfJung
reviewed
Feb 20, 2022
RalfJung
reviewed
Feb 20, 2022
asquared31415
force-pushed
the
open_unix_varargs
branch
from
f549035 to
ac9071e
Compare
RalfJung
reviewed
Mar 5, 2022
asquared31415
force-pushed
the
open_unix_varargs
branch
from
ac9071e to
cf6d32e
Compare
asquared31415
force-pushed
the
open_unix_varargs
branch
from
cf6d32e to
8e97599
Compare
|
Thanks. :) |
|
📌 Commit 8e97599 has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows
libc::opento be called using two or three arguments as defined in https://man7.org/linux/man-pages/man2/open.2.htmlThe presence of the third argument depends on the value of the second argument. If the second argument dictates that the third argument is required miri will emit an error if the argument is missing. If the second argument does not require a third argument, then the argument is ignored and passed as 0 internally (it would be ignored by libc anyway)