Format tests and benches with rustfmt (1-50 of 300) #2244
Merged
+149
−138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtolnay
commented
Jun 20, 2022
RalfJung
reviewed
Jun 20, 2022
| @@ -13,9 +13,7 @@ pub fn main() { | |||
| let b = &mut a as *mut u32; | |||
| let c = EvilSend(b); | |||
| unsafe { | |||
| let j1 = spawn(move || { | |||
| *c.0 | |||
There was a problem hiding this comment.
If we add a trailing ; here, does rustfmt keep the braces? I think I'd prefer that, for symmetry with the other spawn.
There was a problem hiding this comment.
Rustc does not allow that.
error: unused unary operation that must be used
--> tests/fail/data_race/read_write_race.rs:17
|
17 | *c.0;
| ^^^^ the unary operation produces a value
|
= note: `-D unused-must-use` implied by `-D unused`
help: use `let _ = ...` to ignore the resulting value
|
17 | let _ = *c.0;
| +++++++And with let _ = *c.0;, miri does not detect the data race so the test fails.
I can use return *c.0;.
RalfJung
reviewed
Jun 20, 2022
|
Is it the case that this formats test-cargo-miri, bench-cargo-miri, benches completely? Can you add that part to CI already? |
|
|
Yeah "let _ = place;" does not even evaluate the place. (Not a Miri choice, this is done during MIR building.) "let _val = place;" should work.
|
|
Changed to |
This was referenced Jun 20, 2022
|
@bors r+ |
|
📌 Commit 53580c1 has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #2097.
I filtered this PR to contain exclusively "easy" cases to start off with, i.e. where there is no compiletest_rs (or other) comment in the vicinity that might need to get manually repositioned.